View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000114 | HTML & PERL | Bug Report - Database | public | 2005-02-28 18:21 | 2007-12-06 08:02 |
| Reporter | Rar | Assigned To | exp | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0000114: Correct file counts on both database and episode level | ||||
| Description | Now generics have been added to all episodes (by some good backdoor action from wahaha) a few file statistics could do with correcting. Generics are not really files, and should not be reported in counts. Firstly, the total number of files in the database should be reported as (files - episodes) Secondly, each episode should report the number of files for it as (files - 1) | ||||
| Tags | No tags attached. | ||||
|
|
indeed |
|
|
What do you do about myplace statistics? If the above rules are applied then a user could potentially have more files than are in the database... If generics are not counted in myplace though, that would mess with the counts for the # of files and # of eps (and a user could have more episodes than files). |
|
|
eps now report files-1 as filecount, do we really need to change the file stats? |
|
|
If you do, then you get into questions like I posed on what to do with the mylist statistics... I don't think it is necessary to change the file stats. |
|
|
Good to see the files reporting nicely. I don't quite get egg's objection. The only stat that I see in myplace (or anywhere) that shoule be generated from myfilecount is mywatched% - and it's not! Everything else is based off myepcount. So... all this leaves is the theorectial possibility that someone could add more files than the total db count reports. As that's more than three files for *every ep in the db*, I'd suggest that'd be a mod-has-quiet-word-with-user moment. So egg... what stat could potentialy get messed up? I just don't see it. Rar |
|
|
Well, I guess it's not that big of a deal, but it would be possible for a user to have more files than were in the database. It looks like we are currently a long ways off, the [nonhidden] user with the most files has 21182 files and the number of files (subtracting generics) is 93949... The other option (where you would not have to worry about this) is if you also don't count generics in the #files a user has in myplace and in the user lists. This, which is actually somewhat correct, would have the side effect of having users with more episodes than files. I guess I don't care one way or the other if you want to subtract generics from the file statistics, BUT, if you do it make sure it is done everywhere. So if you do it for the main statistics, also do it for mylist and whatever else.... |
|
|
well guess i could bump that and add some more stats that need fix0ring. Eps Watched it's in fact "FILES watched". please consider changing that to to "eps watched". why? because no one cares about files watched. it's uninteresting if i have seen 5 versions of the same episode, because in the end it's still just the same freakin episode. shown when using !mystats (chii), in the internal stats and in myplace. % watched should be: watched eps / total eps in mylist x100 = % watched but is watched files / total eps in mylist x100 = % watched why is that bad? well if you have more seen files than episodes you have >100% and yes there are people like that. besides it's just plain wrong. shown when using !mystats (chii), in the internal stats and in myplace. thats all just minor, but easy enough to fix so go and do it :P |
|
|
That's why I have more than 100% watched :P Ohhh... well, I agree 100% with DerIdiot propositions. |
|
|
http://www.baka-sama.de/chii-mystats-percentage-dirtyfix.patch A patch which calculates the "% watched" as the number of FILES watched and puts this number on the right place in the output string. This should be considered a workaround until the statistics generating code itself is fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-02-28 18:21 | Rar | New Issue | |
| 2005-02-28 20:56 | exp | Note Added: 0000275 | |
| 2005-02-28 20:56 | exp | Assigned To | => exp |
| 2005-02-28 20:56 | exp | Status | new => acknowledged |
| 2005-03-01 06:55 | egg | Note Added: 0000282 | |
| 2005-03-07 17:47 | exp | Note Added: 0000307 | |
| 2005-03-07 17:55 | egg | Note Added: 0000310 | |
| 2005-03-08 07:29 | Rar | Note Added: 0000314 | |
| 2005-03-08 17:32 | egg | Note Added: 0000318 | |
| 2005-05-26 11:04 | DerIdiot | Note Added: 0000482 | |
| 2005-06-03 19:08 | DonGato | Note Added: 0000496 | |
| 2005-08-23 15:48 | bbaab | Note Added: 0000674 | |
| 2006-09-16 19:43 | pelican | Status | acknowledged => assigned |
| 2006-09-16 19:43 | pelican | Assigned To | exp => pelican |
| 2007-07-02 08:24 | epoximator | Assigned To | pelican => exp |
| 2007-07-02 08:24 | epoximator | Status | assigned => resolved |
| 2007-12-06 08:02 | epoximator | Resolution | open => fixed |
