View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002233 | HTML & PERL | Feature Request - Interface | public | 2015-02-01 17:57 | 2015-02-10 01:43 |
| Reporter | CDB-Man | Assigned To | DerIdiot | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Summary | 0002233: Regarding editable creq messages - fixes | ||||
| Description | a) Only the last creq message should be editable or deletable; disable ninja edits/deletes with links b) It should cause creq out of sync if someone edits or deletes before you reply, add mod note, grant, assign, some_other_action, etc c) if a creq is locked, nothing should be editable or deletable d) if a creq is closed, nothing should be editable or deletable === full chat log for reference: [31 Jan 15 21:00] * DerIdiot: there changed [31 Jan 15 21:00] * CDB-Man: if someone edits their creq msg before you send a new reply, will you get creq out of sync? [31 Jan 15 21:00] * CDB-Man: (i assume yes) [31 Jan 15 21:01] * DerIdiot: shouldn't [31 Jan 15 21:01] * DerIdiot: editing doesn't update the timestamp [31 Jan 15 21:01] * CDB-Man: hmm, well if it doesnt, i think its better if it does cause an out of sync [31 Jan 15 21:02] * CDB-Man: idea being creq msg, as evidence, should be minimally editable [31 Jan 15 21:03] * CDB-Man: the other thing, it looks like, all youre doing is hiding the edit msg button when a creq msg is no longer the last msg [31 Jan 15 21:04] * CDB-Man: aka if i somehow still have the edit link to lets say the 2nd last msg, i can still use it to edit it despite not being last msg [31 Jan 15 21:04] * CDB-Man: that's bad imo [31 Jan 15 21:05] * Hinoe: CDB-Man: you can get an edit link from any creq message where yours is the last [31 Jan 15 21:05] * Hinoe: or even save [31 Jan 15 21:05] * Hinoe: all you need then is the id [31 Jan 15 21:05] * Hinoe: and guess what? it's in the "message #x" link [31 Jan 15 21:05] * CDB-Man: 8[21:05:20] Hinoe: and guess what? it's in the "message #x" link <---.......... gee [31 Jan 15 21:05] * Hinoe: so grabbing the edit link for any message is extremely trivial [31 Jan 15 21:06] * DerIdiot: ... [31 Jan 15 21:06] * DerIdiot: fine i will disable editing of messages completely [31 Jan 15 21:06] * DerIdiot: happy? [31 Jan 15 21:07] * CDB-Man: worf: #layout-main div.tabbed_pane ul.tabs li {border: 1px solid;} <--- add that selector and increase it [31 Jan 15 21:07] * Hinoe: not really... [31 Jan 15 21:08] * CDB-Man: personally i prefer non-editable vs all editable; editable only makes sense if a) only last is editable and b) it will cause creq out of sync if someone edits before you reply [31 Jan 15 21:08] * Hinoe: what cdb said | ||||
| Tags | No tags attached. | ||||
