View Issue Details

IDProjectCategoryView StatusLast Update
0002449HTML & PERLFeature Request - Miscpublic2016-04-17 13:19
Reporterbenu Assigned ToDerIdiot  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Summary0002449: song length not taken over automatically for song-collection relations (non-normal) on collection pages + song pages
DescriptionThis is very tricky to describe, thus I will let you know about the "issue" with going through the steps of adding 2 existing songs in each 3 versions to a single:
http://anidb.net/perl-bin/animedb.pl?show=collection&collectionid=8950 collection is "Bravely You Single

The songs added are characterized as
1: s1 original
2: s2 original
3: s1 tv size
4: s2 tv size
5: s1 instrumental
6: s2 instrumental

"Add Songs" --> "Massadd New Songs"

<<<<Step 1>>>>
parsing using "CSV (; separated) - with japanese title"):
1;asdf;;;http://anison.info/data/song/93880.html
2;asdf;;;http://anison.info/data/song/93881.html
3;asdfaf;;1:33;http://anison.info/data/song/93880.html
4;adsfaf;;1:35;http://anison.info/data/song/93881.html
5;adfaf;;;http://anison.info/data/song/93880.html
6;asf;;;http://anison.info/data/song/93881.html
(note: the song title is obscure because this one beautiful feature searches by anison link, which finds the perfect match, only song 3 is going to be a new entry)
(note2: both songs are already added to another collection (in the same order) and have their respective lenghts added s1: http://anidb.net/s81700 // s2 http://anidb.net/s81701)

<<<<Step 2>>>>
"Send"
result Pic 1: http://i.imgur.com/7JyQMIG.png
as you can see, even though there was a parsed length, it automatically filled in the original length into the length box, taken from the linked song. When the linked song does not have a length added (yet), it takes the times that are parsed (1:33 etc.) only taking the "new" time from the original version song-collection link
for comparison: Pic 2: http://i.imgur.com/WKOwxeM.png
This is a song that had no length added before being mass-added to the collection, the first selection will add the length to the original song entry, the second linking as tv-version will take over the time parsed

<<<<Step 3>>>>
"Add Selected"
result Pic 3: http://i.imgur.com/XIkLpbo.png
it (obviously) only took the lengths from the boxes, the original song length,for the tv-size relation type added song

<<<<Step 4>>>>
"Add/edit songs"
fixing the length for the short size manually
Pic 4: http://i.imgur.com/BGTNrVE.png
what is very inconvenient here is that neither type normal nor instrumental only have the length added from the beginning. this is also shown on the song page entry, in related collection tab
Pic 5: song page entry, related collections tab http://imgur.com/G4WCKEc

Suggestion:

existing relations on the collection-song relation page should automatically be fed the main song entry's length for the following types
* normal
* instrumental
* karaoke
existing relations on the collection-song relation page that get fed a different length when massadding songs to it (plus minus 5 seconds of the original song), should get the parsed length fed for the following types:
* tv version
* tv version instrumental
* tv version karaoke
* short version
* movie version

This leaves only 'live version', which might or might not be useful as a song-collection relation type.
Additional Informationthe mass-add will react different depending on the song entry itself, if it has no length added, it will take over all lengths parsed, if it already has a length added, it will only take that length (automatically)
TagsNo tags attached.

Activities

DerIdiot

2016-04-17 13:19

administrator   ~0003750

i hope i got it right what you were askign for. your report itself and steps for reproduction were perfect. rarely do i get proper steps like that. thanks for that.
what was a bit of a pickle to me was figuring out what you actually wanted. it's probably very obvious to you working on this all day long. wasn't to me though. i made some best assumptions. let me know if i got what you wanted.

Issue History

Date Modified Username Field Change
2016-03-28 09:18 benu New Issue
2016-04-16 23:18 DerIdiot Project AniDB Website => HTML & PERL
2016-04-17 13:19 DerIdiot Note Added: 0003750
2016-04-17 13:19 DerIdiot Status new => resolved
2016-04-17 13:19 DerIdiot Resolution open => fixed
2016-04-17 13:19 DerIdiot Assigned To => DerIdiot