View Issue Details

IDProjectCategoryView StatusLast Update
0003460AniDB WebsiteBug Report - Interfacepublic2020-08-23 01:42
Reporterinim Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformChrome 84.0.4147.135OSUbuntuOS Version20.04.1 LTS
Product Version 
Target VersionFixed in Version 
Summary0003460: Editing tags has side effect on existing is_spoiler tags
DescriptionBUG: Editing tags has side effect on existing is_spoiler tags

When editing the tags of a show using the visual editor, a side effect creates CREQs concerning existing tags with the is_spoiler flag.

WORKAROUND:
Revoke the erroneously created CREQ manually, no damage was done yet (unless you are a mod)

REQUESTED FIX:
Fix the submit code so the buggy CREQs aren't created at all.
=========
CDB EDIT:
he reason is because the tag itself, "everybody dies", is marked as a global spoiler: https://anidb.net/tag/3267/edit

Therefore as a global spoiler, it does not need per-entry spoilers. The system cleans these whenever anyone generates an edit via the GUI, and since you were the first person to touch Katanagatari via the GUI, you just happened to be the one that triggered the change.

The edit is intended, therefore, modifying this request to as follows.

Tags marked global spoiler do not need to be marked local spoiler on a per-anime, per-character, etc per entry basis.
Whenever a user or mod uses the GUI tag editor, the system generates a creq, under that user/mod's name, to remove the local spoiler.

User creq:
https://anidb.net/admin/creq/13333190
https://anidb.net/admin/creq/13243019

Modedit creq:
https://anidb.net/admin/creq/13337036

This is very confusing, especially for the user who never changed that tag. As such, similar to how tags deleted via massedit have an auto-generated creq message of "deletion request from massedit", make these spoiler flag cleanup creqs have the following message:
"[b]Notice to user and mod:[/b] This creq was generated by the system under the user's name, to remove the is_spoiler flag from this tagentityrel, because the tag is already marked as a global spoiler. Mods, please grant this routine maintenance creq."
Steps To ReproduceBUG Example / Reproduce:
1. I've added "predominantly adult cast" to https://anidb.net/anime/6613/ Katanagatari using the "Edit tags (GUI)" dialog
2. I've submitted the edit from there
3. A new CREQ on an untouched, unrelated tag was created (and submitted for mod approval) because the "is_spoiler" tag of existing tags is reset to "false"/0
https://anidb.net/admin/creq/13333190

Additional InformationThis happens the 2nd time, so I firmly believe this is a software bug and not some mis-edit on my side. See the first CREQ and it's follow up discussion
https://anidb.net/admin/creq/13243019

Also reported here: https://anidb.net/forum/thread/102228
Tagscreq, editor, tags

Activities

CDB-Man

2020-08-23 01:42

manager   ~0004441

I have added the following commentary:

CDB EDIT:
he reason is because the tag itself, "everybody dies", is marked as a global spoiler: https://anidb.net/tag/3267/edit

Therefore as a global spoiler, it does not need per-entry spoilers. The system cleans these whenever anyone generates an edit via the GUI, and since you were the first person to touch Katanagatari via the GUI, you just happened to be the one that triggered the change.

The edit is intended, therefore, modifying this request to as follows.

Tags marked global spoiler do not need to be marked local spoiler on a per-anime, per-character, etc per entry basis.
Whenever a user or mod uses the GUI tag editor, the system generates a creq, under that user/mod's name, to remove the local spoiler.

User creq:
https://anidb.net/admin/creq/13333190
https://anidb.net/admin/creq/13243019

Modedit creq:
https://anidb.net/admin/creq/13337036

This is very confusing, especially for the user who never changed that tag. As such, similar to how tags deleted via massedit have an auto-generated creq message of "deletion request from massedit", make these spoiler flag cleanup creqs have the following message:
"[b]Notice to user and mod:[/b] This creq was generated by the system under the user's name, to remove the is_spoiler flag from this tagentityrel, because the tag is already marked as a global spoiler. Mods, please grant this routine maintenance creq."

Issue History

Date Modified Username Field Change
2020-08-22 14:15 inim New Issue
2020-08-22 14:15 inim Tag Attached: creq
2020-08-22 14:15 inim Tag Attached: editor
2020-08-22 14:15 inim Tag Attached: tags
2020-08-23 01:42 CDB-Man Description Updated View Revisions
2020-08-23 01:42 CDB-Man Note Added: 0004441