0000389: some more sanity checks for fileadd - AniDB Bug Tracker

ID	Project	Category	View Status	Date Submitted	Last Update

0000389	HTML & PERL	Feature Request - Interface	public	2006-07-16 16:16	2007-01-26 10:11

Reporter	nwa	Assigned To
Priority	normal	Severity	feature	Reproducibility	always
Status	closed	Resolution	won't fix

Summary	0000389: some more sanity checks for fileadd
Description	NT
Additional Information	- give an error message "The container type selected does not support variable frame rate." if (variable frame rate flag == true && file type == .avi (using 0 frames to make the video vfr counts simply as setting the fps to 120) \|\| .divx (god I hope nobody starts using that format nor divx6 so we wouldn't need to add it) \|\| .ogm). - give an error message "md5 hash is NOT an ed2k hash you god damned tard! if (md5 hash == ed2k hash) unless deridiot thinks it's better for users to do this for easier detection later on rather than risk with user adding completely bogus ed2k links. - give an error message "4xCRC hash is NOT an ed2k hash you tard! your nick along with your IP has been recorded along with this malicious intent, you WILL be banned and reported to the FBI" if (ed2k hash = 'crc hash'+'crc hash'+'crc hash'+'crc hash') I think we had this kind of a situation before... unless deridiot thinks it's better for users to do this for easier detection later on (or is it easier, can you do this kind of sql query?) rather than risk with user adding completely bogus ed2k links. - give an error message "Hardsubs do NOT have a trackid." if (hardsub flag = checked && TrackID != -1) I'd prefer it having no id instead of having the video track id, since well, but I guess we can have it have the same id as the video track, too. Or... do what worf said and simply convert any given id to -1, but I think the user adding it should know about it. - give an error message "The same trackid can't be used more than once. if (trackid 0+n = a && trackid 1+n == a) Of course, there should be an exception if it's decided for hardsub and video track to have the same track id. - give an error message "The given video bitrate is wrong for given size and length, use appropriate bitrate calculaters, do NOT get the bitrates from windows xp's file properties." Which values to use for checking, this is the question, but going by the fact, that the audio bitrate is most of the time given correct even in xp's properties, we could go by the formula (vbitrate+abitrate)/81000length = size so we could check the bitrate ourselves with ... uh... um... ^^;;;; vbitrate = (125*length)/size - abitrate ? I suck at math, anway, I realize avdump does it already and so will AOM 0.6 ... but we may need to wait with that some time. Or we can do some simpler check like if file size is 100+ mb and length is 10+ minutes then the bitrate must be bigger than 200 kbps. - give an error message "Only 1 hard subtitle stream per video stream." if video stream nr. count = 1 && hard flag count > 1 If the entire video is hardsubbed, then it only needs 1 sub stream. If the dialogue is softsubbed and karaoke or signs or both are hardsubbed, then it only needs 1 sub stream with either the karaoke or signs or both flags checked.
Tags	No tags attached.

Date Modified	Username	Field	Change
2006-07-16 16:16	DerIdiot	New Issue
2006-07-16 16:16	DerIdiot	Reporter	DerIdiot => nwa
2006-07-16 16:21	nwa	Additional Information Updated
2006-07-16 16:26	nwa	Additional Information Updated
2006-07-22 01:23	fahrenheit	Relationship added	related to 0000460
2007-01-26 10:10	epoximator	Note Added: 0001147
2007-01-26 10:11	epoximator	Status	new => closed
2007-01-26 10:11	epoximator	Resolution	open => won't fix